[libcxx-commits] [PATCH] D136196: [libc++][PMR] Move the pmr::memory_resource destructor into the dylib

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Oct 29 13:08:30 PDT 2022


philnik added a comment.

In D136196#3871517 <https://reviews.llvm.org/D136196#3871517>, @ldionne wrote:

> I am surprised that we don't need to change the ABI list, can you look into why that's not needed?
>
> I would assume it was already exported by the dylib because it wasn't marked with `HIDE_FROM_ABI`, but can you confirm that?

The ABI lists actually need updating, the CI just failed before they were checked.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136196/new/

https://reviews.llvm.org/D136196



More information about the libcxx-commits mailing list