[libcxx-commits] [PATCH] D135824: [libc++] Move preferred_name declarations into the forward declaring headers and add pmr preferred names

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added inline comments.


================
Comment at: libcxx/include/string:652
 #endif
 typedef basic_string<char16_t> u16string;
 typedef basic_string<char32_t> u32string;
----------------
EricWF wrote:
> Aren't we double defining this typedef?
yes, good catch!


================
Comment at: libcxx/include/string:659
-class
-    _LIBCPP_TEMPLATE_VIS
-#ifndef _LIBCPP_HAS_NO_CHAR8_T
----------------
EricWF wrote:
> What happened to `_LIBCPP_TEMPLATE_VIS`?
Looks like I removed that accidentally. Is there any way to test for it currently?


================
Comment at: libcxx/include/string_view:207
 #include <__assert> // all public C++ headers provide the assertion handler
 #include <__config>
 #include <__functional/hash.h>
----------------
EricWF wrote:
> Shouldn't this directly include the forward decl header?
It does, in line 210.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135824/new/

https://reviews.llvm.org/D135824