[libcxx-commits] [PATCH] D135824: [libc++] Move preferred_name declarations into the forward declaring headers and add pmr preferred names

[Eric Fiselier via Phabricator via libcxx-commits]

EricWF added inline comments.


================
Comment at: libcxx/include/__fwd/string.h:57
+
+using u16string = basic_string<char16_t>;
+using u32string = basic_string<char32_t>;
----------------
Second declaration here.


================
Comment at: libcxx/include/regex:6848
 using cmatch  = match_results<const char*>;
-using wcmatch = match_results<const wchar_t*>;
 using smatch  = match_results<std::pmr::string::const_iterator>;
----------------
This would have caused anybody including regex without wchar_t to fail to build, right?

How did we not catch that before?


================
Comment at: libcxx/include/string:652
 #endif
 typedef basic_string<char16_t> u16string;
 typedef basic_string<char32_t> u32string;
----------------
Aren't we double defining this typedef?


================
Comment at: libcxx/include/string:659
-class
-    _LIBCPP_TEMPLATE_VIS
-#ifndef _LIBCPP_HAS_NO_CHAR8_T
----------------
What happened to `_LIBCPP_TEMPLATE_VIS`?


================
Comment at: libcxx/include/string_view:207
 #include <__assert> // all public C++ headers provide the assertion handler
 #include <__config>
 #include <__functional/hash.h>
----------------
Shouldn't this directly include the forward decl header?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135824/new/

https://reviews.llvm.org/D135824