[libcxx-commits] [PATCH] D136908: [libc++] Remove duplication in math_h.pass.cpp and improve coverage

[Hui via Phabricator via libcxx-commits]

huixie90 accepted this revision as: huixie90.
huixie90 added a comment.

LGTM with nits



================
Comment at: libcxx/test/std/depr/depr.c.headers/math_h.pass.cpp:832-834
+#ifndef TEST_HAS_CHAR8_T
+  test_integral_three_args<T, U, char8_t, PromoteResult>();
+#endif
----------------
Slightly confused by the condition. I read it as "If char8_t is NOT defined, then we have the test to test the char8_t"


================
Comment at: libcxx/test/std/depr/depr.c.headers/math_h.pass.cpp:917
+  test_integral_two_args<T, char>();
+#ifndef TEST_HAS_CHAR8_T
+  test_integral_two_args<T, char8_t>();
----------------
same here


================
Comment at: libcxx/test/std/depr/depr.c.headers/math_h.pass.cpp:951
+  test_integral_single_arg<char>();
+#ifndef TEST_HAS_CHAR8_T
+  test_integral_single_arg<char8_t>();
----------------
same here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136908/new/

https://reviews.llvm.org/D136908