[libcxx-commits] [PATCH] D132061: [libc++] static_assert preconditions in vector

[Eric Fiselier via Phabricator via libcxx-commits]

EricWF added a comment.

Please write out a more descriptive explanation of the benifit and rational for this change. It would be nice to have a lot more than a single line attached to the eventual commit.

Additionally, I assume the only thing this does is make the diagnostics for already ill-formed code slightly easier to grok? If so, we should consider whether that improvement is worth the additional compile time cost and maintenance cost.  
Perhaps by providing concrete examples of where the existing diagnostics are grossly insufficient or need improving.



================
Comment at: libcxx/test/libcxx/containers/sequences/vector/preconditions.verify.cpp:29
+  // expected-error@* {{no matching function for call to}}
+  std::vector<NotDefaultInsertable> v1(10);
+
----------------
Can you add an annotation that actually shows that the line below is triggering any diagnostic at all? Something like `// expected-note {{from here}}`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132061/new/

https://reviews.llvm.org/D132061