[libcxx-commits] [PATCH] D136724: [libc++][RFC] Add nullability annotations to string

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

I think this is interesting and it may have some value, however:

1. I wouldn't annotate pointers that don't have any requirement with anything. In other words, I wouldn't use `_Null_unspecified` or `_Nullable` unless there's a benefit to doing that.
2. I would define a libc++ macro for these builtins.

Also, can you link to or explain the full benefits of these builtins? I'm curious to know what the compiler can do with them (is there anything beyond warning if you pass `nulltpr`?).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136724/new/

https://reviews.llvm.org/D136724