[libcxx-commits] [PATCH] D134036: [libc++][format] Implements string escaping.

Chuanqi Xu via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Oct 26 19:18:18 PDT 2022


ChuanqiXu added a comment.

In D134036#3885470 <https://reviews.llvm.org/D134036#3885470>, @erichkeane wrote:

> In D134036#3884982 <https://reviews.llvm.org/D134036#3884982>, @ChuanqiXu wrote:
>
>> @erichkeane I reproduced it but I don't have enough time to look at it actually today.
>
> Whew, at least I'm not the only one having this problem :D  The build-bots for libcxx never caught it, so I was afraid it was a problem with my setup.  I Tried to debug it for a while, and kept getting caught up in the module serialization/deserialization parts, and got lost :/

I'm not sure if we can fix it quickly (I have too many TODOs). It looks like we need require the build-bots for libcxx to get some new setups.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134036/new/

https://reviews.llvm.org/D134036



More information about the libcxx-commits mailing list