[libcxx-commits] [PATCH] D136667: Check return address stored in normal stack and CET shadow stack in unwind process phase2

Tue Oct 25 17:51:59 PDT 2022

xiongji90 added a comment.

In D136667#3883963 <https://reviews.llvm.org/D136667#3883963>, @MaskRay wrote:

> Is there any way to validate correctness without a CET-capable machine?
> Is there any emulator

Hi, @MaskRay 
I am afraid we don't have anyway to validate correctness without a CET-enable machine since the intrinisc "_get_ssp" will return 0 in machine without CET and all the check based on comparison between normal stack ret addr and CET shadow stack ret addr will be skipped.
Currently, I set up a CET enabled machine and ran all libunwind, libcxx, libcxxabi tests in CET mode to validate this patch. In testing, we need to also build libcxx, libcxxabi and corresponding test with CET options on.

Thanks very much.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136667/new/

https://reviews.llvm.org/D136667