[libcxx-commits] [PATCH] D136257: [libc++abi][AIX] Use reserved slot in stack to pass the address of exception object

[Xing Xue via Phabricator via libcxx-commits]

xingxue marked an inline comment as done.
xingxue added inline comments.


================
Comment at: libcxxabi/src/aix_state_tab_eh.inc:664
+  // this function.
+  dummy();
+
----------------
cebowleratibm wrote:
> Suggestion: rename `dummy` to `force_a_stackframe` or similar.  The comments are helpful but the name makes it really hard for anyone to erroneously remove it, noting that you also have tests that would fail if anyone did but the more layers of defense and readability the better.
Renamed as suggested, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136257/new/

https://reviews.llvm.org/D136257