[libcxx-commits] [PATCH] D124516: [libc++] Implement `std::expected` P0323R12

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Oct 21 09:45:06 PDT 2022


ldionne added inline comments.


================
Comment at: libcxx/include/__expected/expected.h:462
+  _LIBCPP_HIDE_FROM_ABI constexpr const _Tp* operator->() const noexcept {
+    _LIBCPP_ASSERT(__has_val_, "expected must contain a value");
+    return std::addressof(__val_);
----------------
We should have `assert.foo.pass.cpp` tests for those!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124516/new/

https://reviews.llvm.org/D124516



More information about the libcxx-commits mailing list