[libcxx-commits] [PATCH] D136257: [libc++abi][AIX] Use reserved slot in stack to pass the address of exception object

Chris Bowler via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Oct 21 07:51:44 PDT 2022


cebowleratibm added inline comments.


================
Comment at: libcxxabi/src/aix_state_tab_eh.inc:664
+  // this function.
+  dummy();
+
----------------
Suggestion: rename `dummy` to `force_a_stackframe` or similar.  The comments are helpful but the name makes it really hard for anyone to erroneously remove it, noting that you also have tests that would fail if anyone did but the more layers of defense and readability the better.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136257/new/

https://reviews.llvm.org/D136257



More information about the libcxx-commits mailing list