[libcxx-commits] [PATCH] D135813: [libc++][PMR] Add availability macros

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Oct 18 10:21:59 PDT 2022


Mordante added inline comments.


================
Comment at: libcxx/include/__memory_resource/unsynchronized_pool_resource.h:74
 
   _LIBCPP_HIDE_FROM_ABI ~unsynchronized_pool_resource() override { release(); }
 
----------------
This function probably needs to be marked too since it calls release.

I usually use the attribute on the entire class/struct.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135813/new/

https://reviews.llvm.org/D135813



More information about the libcxx-commits mailing list