[libcxx-commits] [PATCH] D133517: [SystemZ][z/OS] Add scripts for building libc++/abi

[Muiez Ahmed via Phabricator via libcxx-commits]

muiez marked 2 inline comments as done.
muiez added inline comments.


================
Comment at: libcxx/utils/ci/zos-install-libcxx.sh:14
+#
+set -e
+
----------------
Mordante wrote:
> For my curiosity, why do you need a special script for doing this? Some parts look like general packaging for z/OS. Did you consider to add a cmake cache for z/OS in `cmake/caches`?
> 
> When this really needs those script can you add some explanation why it's needed in the commit message?
We have multiple cmake caches for z/OS in cmake/caches (to handle multiple targets). I updated the revision to use them, since the patch that introduced the z/OS cache files landed recently. I added an explanation to why the scripts are needed in the description. Please let me know if further clarification is needed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133517/new/

https://reviews.llvm.org/D133517