[libcxx-commits] [PATCH] D136050: [libc++] Fix missing requires clause on variant operator<=>

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

LGTM modulo some minor nits.



================
Comment at: libcxx/include/variant:168
 
   template <class... Types>
   constexpr common_comparison_category_t<compare_three_way_result_t<Types>...>
----------------
Please add the requires here too.


================
Comment at: libcxx/test/std/utilities/variant/variant.relops/three_way.pass.cpp:15
 
 // template<class... Types>
 //   constexpr std::common_comparison_category_t<
----------------
Please add the requires here too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136050/new/

https://reviews.llvm.org/D136050