[libcxx-commits] [PATCH] D135777: [libc++] Move functions in math.h into the versioned namespace
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Oct 13 10:13:48 PDT 2022
ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.
Including `<math.h>` should not define functions in namespace `std`. Users should be required to use `<cmath>` in order to get that behavior. Otherwise, this is a portability trap (https://godbolt.org/z/434zs4zz3).
If you think that's necessary for `constexpr cmath`, I'd like to understand why.
Also, let's coordinate with D134938 <https://reviews.llvm.org/D134938> to find a single way forward and avoid duplicate work.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135777/new/
https://reviews.llvm.org/D135777
More information about the libcxx-commits
mailing list