[libcxx-commits] [PATCH] D135548: [libc++] Implement c++20 shared_ptr rvalue overloads.

Wed Oct 12 17:45:08 PDT 2022

pateldeev marked 9 inline comments as done.
pateldeev added inline comments.

================
Comment at: libcxx/include/__memory/shared_ptr.h:594

+#if _LIBCPP_STD_VER > 20
+    template <class _Yp>
----------------
Mordante wrote:
> Mordante wrote:
> > Please update the synopsis too.
> We (and other vendors) typically backport LWG-issue, can you do that for this issue too.
I think back-porting to c++17 will break code that does a `std::move()` but relies on the fact that no move happens. Arguable this a just a bug in user code, but probably still something we don't want to change?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135548/new/

https://reviews.llvm.org/D135548