[libcxx-commits] [PATCH] D134221: [runtimes] Always define the cxx_shared, cxx_static & other targets

[Peter Collingbourne via Phabricator via libcxx-commits]

pcc added a comment.

TSan builds are also broken with this change: https://lab.llvm.org/buildbot/#/builders/70/builds/28491

  ld: error: undefined symbol: __tsan_func_entry
  >>> referenced by cxa_aux_runtime.cpp
  >>>               libcxxabi/src/CMakeFiles/cxxabi_shared_objects.dir/cxa_aux_runtime.cpp.o:(__cxa_bad_cast)
  >>> referenced by cxa_aux_runtime.cpp
  >>>               libcxxabi/src/CMakeFiles/cxxabi_shared_objects.dir/cxa_aux_runtime.cpp.o:(__cxa_bad_typeid)
  >>> referenced by cxa_aux_runtime.cpp
  >>>               libcxxabi/src/CMakeFiles/cxxabi_shared_objects.dir/cxa_aux_runtime.cpp.o:(__cxa_throw_bad_array_new_length)
  >>> referenced 539 more times

(and more undefined symbols).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134221/new/

https://reviews.llvm.org/D134221