[libcxx-commits] [PATCH] D133517: [SystemZ][z/OS] Add scripts for building libc++/abi

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/utils/ci/tso_copy_dataset.sh:10
+#===----------------------------------------------------------------------===##
+
+end_of_opts=0
----------------
Can you add a short comment what this script does?


================
Comment at: libcxx/utils/ci/zos-install-libcxx.sh:14
+#
+set -e
+
----------------
For my curiosity, why do you need a special script for doing this? Some parts look like general packaging for z/OS. Did you consider to add a cmake cache for z/OS in `cmake/caches`?

When this really needs those script can you add some explanation why it's needed in the commit message?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133517/new/

https://reviews.llvm.org/D133517