[libcxx-commits] [PATCH] D133638: [libc++] static_assert that rebinding the allocator works as expected

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Oct 12 07:16:15 PDT 2022


ldionne added a comment.

I agree with @philnik 's diagnostic here but I'd like to strongly +1 the request to improve the error message. Perhaps we should change this to `static_assert(__check_allocator_requirements<allocator_type>, "");` and then have `__check_allocator_requirements` validate a few properties of the allocator, including that it has `rebind`, and then that such `rebind` behaves as expected.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133638/new/

https://reviews.llvm.org/D133638



More information about the libcxx-commits mailing list