[libcxx-commits] [PATCH] D135180: [NFC][libc++] Moves transitive includes location.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D135180#3849970 <https://reviews.llvm.org/D135180#3849970>, @ldionne wrote:

> Regardless, I agree that this would probably inhibit the header guard optimization from triggering, which would be rather bad. I think we should keep the parts of this change that move transitive includes from the top to the bottom of the header, but drop the parts that move them outside of the include guards. Sorry for my misleading comment on D133212 <https://reviews.llvm.org/D133212>.

Also, that wasn't necessarily clear from the previous interactions on this patch, but I originally thought this was just moving stuff from the top to the bottom of includes -- it didn't click that the patch was actually moving stuff from inside to outside the header guards.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135180/new/

https://reviews.llvm.org/D135180