[libcxx-commits] [PATCH] D135288: [NFC][libc++][format] Improves tests.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libcxx/test/std/utilities/format/format.functions/format.locale.pass.cpp:34
+auto test =
+    []< class CharT, class... Args>(
+        std::basic_string_view<CharT> expected, test_format_string<CharT, Args...> fmt, Args&&... args) constexpr {
----------------
Here and elsewhere.


================
Comment at: libcxx/test/std/utilities/format/format.functions/format_tests.h:189
   // *** Valid input tests ***
   // Unsed argument is ignored. TODO FMT what does the Standard mandate?
+  check(SV("hello world"), SV("hello {}"), world, universe);
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135288/new/

https://reviews.llvm.org/D135288