[libcxx-commits] [PATCH] D112368: [libc++][format] Move iterators when needed.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxx/test/std/utilities/format/format.formatter/format.context/format.context/advance_to.pass.cpp:48
+      std::make_format_args<
+          std::basic_format_context<move_only_push_back_iterator<std::basic_string<char>>, char>>()));
 
----------------
Can we not use `cpp20_output_iterator<std::back_insert_iterator<...>>` and avoid defining our own `move_only_push_back_iterator`?


================
Comment at: libcxx/test/std/utilities/format/format.functions/format_to.pass.cpp:43
     std::list<CharT> out;
     std::format_to(std::back_inserter(out), fmt.template sv<CharT>(), args...);
     assert(std::equal(out.begin(), out.end(), expected.begin(), expected.end()));
----------------
This looks like a merge conflict to me. I think you meant to mirror the changes in `format_to.locale.pass.cpp`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112368/new/

https://reviews.llvm.org/D112368