[libcxx-commits] [PATCH] D131317: [libc++] Implements constexpr <charconv>.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked 6 inline comments as done.
Mordante added inline comments.


================
Comment at: libcxx/include/__charconv/tables.h:30
 /// charconv for integrals in C++11 mode.
+#if _LIBCPP_STD_VER > 14
+// TODO(mordante) look at consolidating the tables for C++11/14 and C++17/20/2b
----------------
philnik wrote:
> Mordante wrote:
> > philnik wrote:
> > > What is the difference between the versions? Why can't the arrays be constexpr before C++17?
> > No `inline constexpr` before C++17. I want to look at this later but prefer to move that out of this change.
> Isn't this in the class to achieve the same effect? Clang seems to be happy with that in C++11: https://godbolt.org/z/c6nz39xbv
Changed to `inline constexpr` instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131317/new/

https://reviews.llvm.org/D131317