[libcxx-commits] [PATCH] D134479: [libc++] Split __allocator_destructor out of shared_ptr.h

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Oct 6 16:31:16 PDT 2022


philnik added inline comments.


================
Comment at: libcxx/include/__memory/allocator_destructor.h:36
+    _LIBCPP_INLINE_VISIBILITY
+    void operator()(pointer __p) _NOEXCEPT
+        {__alloc_traits::deallocate(__alloc_, __p, __s_);}
----------------
huixie90 wrote:
> nit: can this member function be `const`?
Maybe, but I wouldn't change it here, since I'm just moving the code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134479/new/

https://reviews.llvm.org/D134479



More information about the libcxx-commits mailing list