[libcxx-commits] [PATCH] D134952: [libc++][ranges]implement `std::views::take_while`

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

FWIW, I would be okay with marking the tests as `XFAIL: clang-14, clang-15` unless the workaround in `take_while_view` for that compiler bug is really simple.

The reason why I'm so keen to do this is that our support for older clangs is mainly to make sure that people's CI systems keep working fine as we make changes, but we don't actually expect a lot of vendors to ship a new libc++ with an old clang. And users of such a setup that end up using `take_while_view` should be even more rare. Anyway, I'm fine either way, but this is just the justification for why I'm happy with marking the test as XFAIL if the workaround introduces a lot of tech debt in libc++ (which we will likely not remove in the future unless it's clearly marked as such).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134952/new/

https://reviews.llvm.org/D134952