[libcxx-commits] [PATCH] D133317: [libc++][ranges] implement `std::views::istream`

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libcxx/docs/Status/RangesPaper.csv:162
+`[range.reverse] <https://wg21.link/range.reverse>`_,`reverse_view <https://llvm.org/D107096>`_,[range.all],Zoe Carver,✅
\ No newline at end of file

----------------
Newline!


================
Comment at: libcxx/test/std/ranges/range.factories/range.istream.view/utils.h:8
+template <class CharT, std::size_t N>
+auto makeString(const char (&in)[N]) {
+  std::basic_string<CharT> r(N - 1, static_cast<CharT>(0));
----------------
For functions we generally use `snake_case`, although we might not be 100% consistent everywhere. I think it would still be better to try to stick to `snake_case`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133317/new/

https://reviews.llvm.org/D133317