[libcxx-commits] [PATCH] D118620: [SystemZ][z/OS] Build several exception derived classes as a separate library

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik accepted this revision as: philnik.
philnik added a comment.

LGTM with comments applied. Leaving final approval to @ldionne.



================
Comment at: libcxx/src/exceptions/any.cpp:1
+//===----------------------------------------------------------------------===//
+////
----------------
I wouldn't bother with putting every one of these into it's own file.


================
Comment at: libcxx/src/exceptions/memory.cpp:2-9
+//===----------------------------------------------------------------------===//
+////
+//// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+//// See https://llvm.org/LICENSE.txt for license information.
+//// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+////
+////===----------------------------------------------------------------------===//
----------------
The license headers seem to be broken in a few places.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118620/new/

https://reviews.llvm.org/D118620