[libcxx-commits] [PATCH] D135297: [libc++] Add test for bug that had been introduced in D98573 and fixed in D119633

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik accepted this revision.
philnik added a comment.
This revision is now accepted and ready to land.

In D135297#3837655 <https://reviews.llvm.org/D135297#3837655>, @ldionne wrote:

> If you revert D119633 <https://reviews.llvm.org/D119633>, this test starts failing. It looks like we forgot to add a test when we made D98573 <https://reviews.llvm.org/D98573>, but I think it might be because the motivation for making the change was not fixing this bug, it was implementing `constexpr string`.

I was indeed not aware that the patch fixed a bug. LGTM % comments.



================
Comment at: libcxx/test/std/strings/basic.string/string.modifiers/string_insert/iter_iter_iter.infinite_recursion.pass.cpp:27-29
+namespace std {
+    template <>
+    struct char_traits<char_ascii> {
----------------



================
Comment at: libcxx/test/std/strings/basic.string/string.modifiers/string_insert/iter_iter_iter.infinite_recursion.pass.cpp:94
+        static char_type* copy(char_type* dest, char_type const* src, std::size_t count) {
+            return move(dest, src, count);
+        }
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135297/new/

https://reviews.llvm.org/D135297