[libcxx-commits] [PATCH] D135163: [libc++] Get rid of _LIBCPP_HAS_OPEN_WITH_WCHAR in the test suite

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/test/libcxx/input.output/file.streams/fstreams/fstream.members/open_wchar_pointer.pass.cpp:23
 #include "test_macros.h"
-#include "platform_support.h"
+#include "../wide_temp_file.h"
 
----------------
ldionne wrote:
> Mordante wrote:
> > I'm not fond of include paths containing `..` since it may include files at unexpected locations.
> > How about moving this file to the `test/support` directory instead?
> I can do that, but I'm not sure how this can end up selecting a file at an unexpected location, since the current directory is always the first path that the preprocessor looks in for `""` style includes.
I've had issues with `..` in the past, but it no longer occur with newer compilers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135163/new/

https://reviews.llvm.org/D135163