[libcxx-commits] [PATCH] D134138: [libc++][chrono] Implements formatter month.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked an inline comment as done.
Mordante added inline comments.


================
Comment at: libcxx/test/std/time/time.cal/time.cal.month/time.cal.month.nonmembers/ostream.pass.cpp:16-17
+
+// REQUIRES: locale.fr_FR.UTF-8
+// REQUIRES: locale.ja_JP.UTF-8
+
----------------
ldionne wrote:
> Can you double-check that these tests are getting run at all in our CI? It seems rather suspicious to me that the no-localization CI job didn't fail despite using the incorrect `// UNSUPPORTED: libcpp-has-no-localization` formulation above.
I verified and these tests are executed in the CI.
(I would be surprised if they weren't since a lot of the platform specific output have been found by the CI.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134138/new/

https://reviews.llvm.org/D134138