[libcxx-commits] [PATCH] D133216: [libc++] Make charconv require C++17 or later.

Wed Oct 5 08:57:24 PDT 2022

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

In D133216#3834376 <https://reviews.llvm.org/D133216#3834376>, @philnik wrote:

> I think it's a good idea, but this is ultimately a vendor question, so I'll leave final approval to Louis.

I did an internal survey and couldn't find any uses of the extension. It doesn't mean that it'll break zero code, but I don't think it's going to be a big deal (for instance the removal of `binary_function` and `unary_function` was much more disruptive but we still did it).

================
Comment at: libcxx/docs/ReleaseNotes.rst:83-84
+  C++14 as an undocumented extension. This extension makes it hard to implement
+  the C++23 paper that makes these functions ``constexpr``. Therefore extension
+  has been removed.
+
----------------

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133216/new/

https://reviews.llvm.org/D133216