[libcxx-commits] [PATCH] D134479: [libc++] Split __allocator_destructor out of shared_ptr.h

Hui via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Oct 5 00:17:32 PDT 2022


huixie90 accepted this revision.
huixie90 added a comment.

LGTM



================
Comment at: libcxx/include/__memory/allocator_destructor.h:36
+    _LIBCPP_INLINE_VISIBILITY
+    void operator()(pointer __p) _NOEXCEPT
+        {__alloc_traits::deallocate(__alloc_, __p, __s_);}
----------------
nit: can this member function be `const`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134479/new/

https://reviews.llvm.org/D134479



More information about the libcxx-commits mailing list