[libcxx-commits] [PATCH] D118930: [SystemZ]:[z/OS]:[libcxx]: fix the mask in stage2_float_loop function

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Oct 4 14:27:01 PDT 2022


philnik added a comment.

In D118930#3834907 <https://reviews.llvm.org/D118930#3834907>, @NancyWang2222 wrote:

> In D118930#3354564 <https://reviews.llvm.org/D118930#3354564>, @ldionne wrote:
>
>> Please use `std::` instead of `_VSTD::`, though (as suggested by @philnik)
>
> hi Louis, sorry for late reply, haven't been active working on this for a while. I noticed there are many other places using '_VSTD::' in 'libcxx/include/locale' as well.  I think should replace all of them to "std::" in separate patch.  Thanks

We don't want to replace all the `_VSTD`s in libc++ at once, since there we still have it in a lot of places (> 3300 uses), but we don't want to introduce new uses.  The idea is to remove `_VSTD` when we touch the code anyways.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118930/new/

https://reviews.llvm.org/D118930



More information about the libcxx-commits mailing list