[libcxx-commits] [PATCH] D135163: [libc++] Get rid of _LIBCPP_HAS_OPEN_WITH_WCHAR in the test suite
Mark de Wever via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Oct 4 11:04:02 PDT 2022
Mordante accepted this revision.
Mordante added a comment.
LGTM modulo one comment.
================
Comment at: libcxx/test/libcxx/input.output/file.streams/fstreams/fstream.members/open_wchar_pointer.pass.cpp:23
#include "test_macros.h"
-#include "platform_support.h"
+#include "../wide_temp_file.h"
----------------
I'm not fond of include paths containing `..` since it may include files at unexpected locations.
How about moving this file to the `test/support` directory instead?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135163/new/
https://reviews.llvm.org/D135163
More information about the libcxx-commits
mailing list