[libcxx-commits] [PATCH] D133216: [RFC][libc++] Make charconv require C++17 or later.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante created this revision.
Mordante added a reviewer: ldionne.
Herald added a project: All.
Mordante updated this revision to Diff 457777.
Mordante added a comment.
Mordante edited the summary of this revision.
Mordante updated this revision to Diff 465078.
Mordante edited the summary of this revision.
Mordante added a reviewer: libc++ vendors.
Mordante published this revision for review.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

Rebased and changed XFAIL to UNSUPPORTED as it should be.


ldionne added a comment.

We would need to add a release note.


ldionne added a comment.

Note to self: 100513369


ldionne added a comment.

I do not foresee this being a big issue. I didn't find any instances of code breaking internally, which should give a rough idea that this is not a super commonly relied on extension.


Mordante added a comment.

Rebased and updates release notes.


Implementing the paper
P2291R3 Add Constexpr Modifiers to Functions to_chars and from_chars for

  Integral Types in <charconv> Header

Gives issues in language versions prior to C++17. As suggested in
D131855 <https://reviews.llvm.org/D131855> disable the code prior to C++17. This removes libc++'s
extension.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D133216

Files:
  libcxx/docs/ReleaseNotes.rst
  libcxx/include/__charconv/chars_format.h
  libcxx/include/__charconv/from_chars_result.h
  libcxx/include/__charconv/tables.h
  libcxx/include/__charconv/to_chars_base_10.h
  libcxx/include/__charconv/to_chars_result.h
  libcxx/include/charconv
  libcxx/test/std/utilities/charconv/charconv.from.chars/integral.bool.fail.cpp
  libcxx/test/std/utilities/charconv/charconv.from.chars/integral.pass.cpp
  libcxx/test/std/utilities/charconv/charconv.from.chars/integral.roundtrip.pass.cpp
  libcxx/test/std/utilities/charconv/charconv.syn/chars_format.pass.cpp
  libcxx/test/std/utilities/charconv/charconv.to.chars/integral.bool.fail.cpp
  libcxx/test/std/utilities/charconv/charconv.to.chars/integral.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D133216.465078.patch
Type: text/x-patch
Size: 7975 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20221004/b7322519/attachment.bin>