[libcxx-commits] [PATCH] D135163: [libc++] Get rid of _LIBCPP_HAS_OPEN_WITH_WCHAR in the test suite

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik accepted this revision.
philnik added a comment.
This revision is now accepted and ready to land.

LGTM % comment.



================
Comment at: libcxx/test/libcxx/input.output/file.streams/fstreams/wide_temp_file.h:18
+
+_LIBCPP_SUPPRESS_DEPRECATED_PUSH
+inline std::wstring get_wide_temp_file_name() {
----------------
Since we are in the test suite I'd rather use `TEST_DIAGNOSTIC_PUSH`, `TEST_CLANG_DIAGNOSTIC_IGNORED` and `TEST_DIAGNOSTIC_POP`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135163/new/

https://reviews.llvm.org/D135163