[libcxx-commits] [PATCH] D133081: [libc++] Granularize __tuple

[Michał Górny via Phabricator via libcxx-commits]

mgorny added a comment.

Replacing a file with a directory (and the other way arond) is problematic in general. E.g. if you attempt to `ninja install` it on top of the existing installation:

  CMake Error at libcxx/include/cmake_install.cmake:2190 (file):
    file INSTALL destination: /tmp/z/usr/local/include/c++/v1/__tuple is not a
    directory.
  Call Stack (most recent call first):
    libcxx/cmake_install.cmake:47 (include)
    cmake_install.cmake:48 (include)

While this is normally not a problem for distributions since we use a staging area (i.e. `DESTDIR`), Gentoo's package manager does not support cleanly performing the opposite, i.e. replacing the (non-empty at time of install) directory back with the file on downgrade.

Could we please rename `__tuple` now to avoid name clash and the problems caused by it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133081/new/

https://reviews.llvm.org/D133081