[libcxx-commits] [PATCH] D131395: [libc++] Implement `lexicographical_compare_three_way`

[Johel Ernesto Guerrero Peña via Phabricator via libcxx-commits]

JohelEGP added inline comments.


================
Comment at: libcxx/include/__algorithm/lexicographical_compare_three_way.h:100
+    return __lexicographical_compare_three_way_fast_path(
+        __first1, __last1, __first2, __last2, std::forward<_Cmp>(__comp));
+  } else {
----------------
avogelsgesang wrote:
> Mordante wrote:
> > Is `forward` intended? `__comp` is passed by value.
> good catch! Changed to `move`
I think `ref(__comp)` is the preferred way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131395/new/

https://reviews.llvm.org/D131395