[libcxx-commits] [PATCH] D131395: [libc++] Implement `lexicographical_compare_three_way`

[Adrian Vogelsgesang via Phabricator via libcxx-commits]

avogelsgesang updated this revision to Diff 478741.
avogelsgesang marked 4 inline comments as done.
avogelsgesang added a comment.

- `forward` -> `move`
- move iterator initialization out of benchmarking loop
- remove `#if _LIB_CPP_VERSION` check from benchmark


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131395/new/

https://reviews.llvm.org/D131395

Files:
  libcxx/benchmarks/CMakeLists.txt
  libcxx/benchmarks/lexicographical_compare_three_way.bench.cpp
  libcxx/docs/Status/Cxx20Issues.csv
  libcxx/docs/Status/Cxx2bIssues.csv
  libcxx/docs/Status/SpaceshipProjects.csv
  libcxx/include/CMakeLists.txt
  libcxx/include/__algorithm/lexicographical_compare_three_way.h
  libcxx/include/algorithm
  libcxx/include/module.modulemap.in
  libcxx/test/libcxx/private_headers.verify.cpp
  libcxx/test/std/algorithms/alg.sorting/alg.three.way/lexicographical_compare_three_way.pass.cpp
  libcxx/test/std/algorithms/alg.sorting/alg.three.way/lexicographical_compare_three_way_comp.pass.cpp
  libcxx/test/std/algorithms/alg.sorting/alg.three.way/lexicographical_compare_three_way_comp.verify.cpp
  libcxx/test/support/almost_satisfies_types.h
  libcxx/test/support/test_comparisons.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131395.478741.patch
Type: text/x-patch
Size: 36688 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20221129/e3586176/attachment-0001.bin>