[libcxx-commits] [PATCH] D138601: [libc++] Fix memory leaks when throwing inside std::vector constructors

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D138601#3957922 <https://reviews.llvm.org/D138601#3957922>, @var-const wrote:

> @philnik Thanks a lot for fixing this! Just to double-check -- you have considered reintroducing the base class for the purpose of providing exception safety [...]

FWIW my vote here would be for the current approach, which is more explicit. There's not that much duplication and it makes the code extremely explicit about what operations we're expecting to potentially fail.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138601/new/

https://reviews.llvm.org/D138601