[libcxx-commits] [PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb added a comment.

> The clang-side interface to this seems a touch clunky, and I fear it'll make continuing its use/generalizing its use less likely.

Is this w.r.t. the `FormatDiagnostic` being split up, or is it something else? If it's the former: I'll be changing that to `FormatLegacyDiagnostic`, which //almost// gets us back to where we started.



================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:4520
+  DiagReason<
+    /*Legacy:*/"invalid explicitly-specified argument for template parameter %0",
+    /*SARIF:*/"we passed a %select{type|value|class template}1 as our %ordinal2 "
----------------
erichkeane wrote:
> Already kidna hate this format here.  Is there any way we could make this be something more like:
> 
> `DiagReason<Legacy<"whatever">, SARIF<"whatever">>` ?
I like this suggestion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138939/new/

https://reviews.llvm.org/D138939