[libcxx-commits] [PATCH] D135248: [libc++] implement move_iterator<T*> should be a random access iterator

Eric Fiselier via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Nov 29 12:47:04 PST 2022


EricWF added a comment.

In D135248#3919379 <https://reviews.llvm.org/D135248#3919379>, @phyBrackets wrote:

> Hey @EricWF , could you please take a look at this patch, i guess there are some tests which got affected by this . I'm not sure if i need to update them for passing the CI?

It looks to me that there are still issues with this patch changing the implementation prior to C++20. Please fix that (see the existing inline comments).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135248/new/

https://reviews.llvm.org/D135248



More information about the libcxx-commits mailing list