[libcxx-commits] [PATCH] D137451: [CMake] Use LLVM_TARGET_TRIPLE in runtimes

[David Tenty via Phabricator via libcxx-commits]

daltenty added a comment.

This patch seem to do a bit more than it's description implies. It makes `LLVM_DEFAULT_TARGET_TRIPLE` no longer an valid option on the `runtimes` path:

  CMake Warning:
    Manually-specified variables were not used by the project:
  
      LLVM_DEFAULT_TARGET_TRIPLE

Is this intended? Currently `LLVM_DEFAULT_TARGET_TRIPLE` is the only option we actually document for changing the target triple (https://llvm.org/docs/CMake.html), so now the support options seem kind of inconsistent (though I don't fully grok the intended distinction between  `LLVM_DEFAULT_TARGET_TRIPLE` and `LLVM_TARGET_TRIPLE`, which may be part of the problem).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137451/new/

https://reviews.llvm.org/D137451