[libcxx-commits] [PATCH] D137451: [CMake] Use LLVM_TARGET_TRIPLE in runtimes

[Petr Hosek via Phabricator via libcxx-commits]

phosek added inline comments.


================
Comment at: runtimes/CMakeLists.txt:156
 get_host_triple(LLVM_HOST_TRIPLE)
 set(LLVM_DEFAULT_TARGET_TRIPLE "${LLVM_HOST_TRIPLE}" CACHE STRING
   "Default target for which the runtimes will be built.")
----------------
smeenai wrote:
> We were previously setting `LLVM_DEFAULT_TARGET_TRIPLE` as part of our configure, so this CACHE setting would never take effect. We'll now set it to the host triple, which seems potentially undesirable?
Great point, after thinking about this a bit more, I think it'd be best to drop `LLVM_DEFAULT_TARGET_TRIPLE` altogether and replace it with `LLVM_TARGET_TRIPLE`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137451/new/

https://reviews.llvm.org/D137451