[libcxx-commits] [PATCH] D138189: [libcxx] adds an include-what-you-use (IWYU) mapping file

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb added inline comments.


================
Comment at: libcxx/utils/generate_iwyu_mapping.py:38
+        public = []
+        match i:
+            case '__assert': continue
----------------
ldionne wrote:
> It seems that this is only supported starting with Python 3.10.
> 
> I'm not sure what's the oldest version that LLVM supports, but I think it's older than 3.10, so I'll change this to an if-else chain. No action item, I just wanted to give a heads up.
Thanks, I'll keep this in mind for next time. I was a bit apprehensive about using the feature because it was so new, but it looked like CI was happy with it, so I thought it would be okay.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138189/new/

https://reviews.llvm.org/D138189