[libcxx-commits] [PATCH] D138795: [libc++] Don't assume that string_view::const_iterator is a raw pointer

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Nov 28 05:05:48 PST 2022


ldionne created this revision.
ldionne added a reviewer: Mordante.
Herald added a project: All.
ldionne requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

Our implementation of std::format assumed that string_view's iterators
were raw pointers in various places. If we want to introduce a checked
iterator in debug mode, that won't be true anymore. This patch removes
that assumption.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D138795

Files:
  libcxx/include/__format/format_functions.h
  libcxx/include/__format/format_string.h
  libcxx/include/__format/formatter_output.h
  libcxx/include/__format/parser_std_format_spec.h
  libcxx/include/__format/unicode.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D138795.478197.patch
Type: text/x-patch
Size: 20769 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20221128/e2b1e2f6/attachment-0001.bin>


More information about the libcxx-commits mailing list