[libcxx-commits] [PATCH] D138728: [libc++] Install llvm-dev in the docker image

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Nov 25 09:31:30 PST 2022


Mordante added a comment.

Thanks for working on this!



================
Comment at: libcxx/utils/ci/Dockerfile:88
+# Install llvm-dev to compile custom clang-tidy checks
+RUN apt-get update && apt-get install llvm-$(LLVM_HEAD_VERSION)-dev
+
----------------
I would prefer to install `$(($LLVM_HEAD_VERSION - 1))` add `$(($LLVM_HEAD_VERSION - 2))`. Then we use released versions of clang-tidy headers instead of the development version. We do the same for clang-tidy itself.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138728/new/

https://reviews.llvm.org/D138728



More information about the libcxx-commits mailing list