[libcxx-commits] [PATCH] D138268: [libcxx] Fix std::equal not accepting volatile types by refactoring __equal_to

[Alvin Wong via Phabricator via libcxx-commits]

alvinhochun added a comment.

In D138268#3949449 <https://reviews.llvm.org/D138268#3949449>, @ldionne wrote:

> In D138268#3939747 <https://reviews.llvm.org/D138268#3939747>, @alvinhochun wrote:
>
>> The CI build seems to have been stuck. @ldionne do you know what's going on? (I was told on IRC to ping you.)
>
> We've been having some trouble with the CI lately, but it should more or less be resolved now.

Thanks.

> That being said, this patch needs work. You are changing several algorithms but only adding tests to `std::equal`.

My impression was that the existing tests would have been enough to cover them, because to the other algorithms this is just a refactoring. The main change allowing `__equal_to` to work with volatile types is already tested through the updated test of `std::equal`, which is the focus in the original issue report.

> Also, we probably have a similar problem in `__less`?

It might be. I didn't look into it because I don't have a case that triggers the issue and I only planned to fix the bug I reported at first.

I could come back to this later if nobody has handled it...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138268/new/

https://reviews.llvm.org/D138268