[libcxx-commits] [PATCH] D138307: [libc++] Remove default definition of std::char_traits

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D138307#3947514 <https://reviews.llvm.org/D138307#3947514>, @rnk wrote:

> Sounds like we're on the same page. I agree, the definition of "reasonable" is subjective and hard to know ahead of time, and I don't expect everyone to always agree. I'm satisfied as long as folks are willing to compromise from time to time and work together.

Yes, absolutely. We really appreciate this kind of feedback from downstreams since it allows us to catch things that would be painful for people when migrating, and you can be certain that we are willing to compromise within reason to give folks a good user experience. Of course, we also have to take into account multiple factors, so sometimes it may not be possible to compromise as much as downstreams would like, but I think success lies in the existence of a dialogue like we're having here. For example, I think that the current migration path (where we keep all specializations of `std::char_traits` for some time) is a better choice than what we started with. It's simpler for the library and it provides a better user experience, so everyone wins from that.

In D138307#3947516 <https://reviews.llvm.org/D138307#3947516>, @mcgrathr wrote:

> This broke some existing cases using `std::basic_string_view<std::byte>` and the like.

Yes, please see the above discussion. This will be restored for the time being with a deprecation warning and then removed in an upcoming release (currently planning for LLVM 18).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138307/new/

https://reviews.llvm.org/D138307