[libcxx-commits] [PATCH] D138307: [libc++] Remove default definition of std::char_traits

[Reid Kleckner via Phabricator via libcxx-commits]

rnk added a comment.

In D138307#3947486 <https://reviews.llvm.org/D138307#3947486>, @ldionne wrote:

> I think the currently proposed approach in D138596 <https://reviews.llvm.org/D138596> handles that -- you basically get a deprecation warning that can be turned off via the usual deprecation-removal mechanism, and then roughly one year from now,  this becomes a hard error. I think this is very close to what you mention, unless I am misunderstanding something. Please let me know if D138596 <https://reviews.llvm.org/D138596> doesn't solve your problem.

Thanks, that sounds good to me.

> I think another important thing to note here is that the project was not as active for some years, so folks perhaps got used to ultimate stability. Anyway, I'm all for providing reasonable migration paths when it's reasonable to do so, but the meaning of reasonable is what I expect we may have challenges agreeing on (not just you and me, but the overall LLVM/libc++ community and its downstream users).

Sounds like we're on the same page. I agree, the definition of "reasonable" is subjective and hard to know ahead of time, and I don't expect everyone to always agree. I'm satisfied as long as folks are willing to compromise from time to time and work together.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138307/new/

https://reviews.llvm.org/D138307